Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing sig-spotlights info #7294

Merged
merged 1 commit into from
May 14, 2023
Merged

Missing sig-spotlights info #7294

merged 1 commit into from
May 14, 2023

Conversation

fykaa
Copy link
Member

@fykaa fykaa commented May 14, 2023

This Github pull request updates the SIG Spotlight Thread with accurate links and details for the SIG Network spotlight, which were previously missing. The changes have been carefully made to ensure accuracy and relevance. It is my hope that this pull request is deemed valuable and appropriate for merging :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @fykaa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/community-management area/contributor-comms Issues or PRs related to the upstream marketing team sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels May 14, 2023
@fsmunoz
Copy link
Contributor

fsmunoz commented May 14, 2023

Thank you @fykaa !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2023
@fsmunoz
Copy link
Contributor

fsmunoz commented May 14, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2023
@fsmunoz
Copy link
Contributor

fsmunoz commented May 14, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, fykaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0cbf136 into kubernetes:master May 14, 2023
@fykaa fykaa mentioned this pull request Aug 15, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsmunoz fsmunoz Awaiting requested review from fsmunoz

@imnmo imnmo Awaiting requested review from imnmo

Assignees

@fsmunoz fsmunoz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/contributor-comms Issues or PRs related to the upstream marketing team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fykaa @k8s-ci-robot @fsmunoz